Fix #12656 by setting the proper reporter for inlined methods

[soronpo]

Fixes #12656

[soronpo]

@nicolasstucki I get a pickling test diff:

***** before-pickling.txt
                    <
                      <[ : scala.compiletime.testing.Error]:scala.Array[scala.compiletime.testing.Error]>@
                        tests\run\i12656.scala<108..108>
***** AFTER-PICKLING.TXT
                    <
                      <[ : scala.compiletime.testing.Error]:Seq[scala.compiletime.testing.Error]>@
                        tests\run\i12656.scala<108..108>
*****

Not sure what to do with this.

[nicolasstucki]

You can add it to compiler/test/dotc/run-test-pickling.blacklist for now. It might be good to open another issue on this. It does require investigation.

[soronpo]

I've discovered that this issue hid another bug. It seems that when an implicit macro issues an error message, a non-transparent inline function wrapper fails to pick it up. If the function is transparent, then it works as expected:

trait MacroErr
object MacroErr:
  import scala.quoted.*
  inline given MacroErr = ${ macroErr }
  def macroErr(using Quotes): Expr[MacroErr] =
    import quotes.reflect.*
    '{ compiletime.error("some macro error") }

inline def expectCompileError(
  inline code: String,
  expectedMsg: String
) =
  val errors = compiletime.testing.typeCheckErrors(code)
  assert(errors.head.message == expectedMsg, (errors.head.message, expectedMsg))

@main def Test = expectCompileError("""summon[MacroErr]""", "some macro error")

Exception in thread "main" java.lang.AssertionError: assertion failed: (no implicit argument of type MacroErr was found for parameter x of method summon in object Predef.
I found:

    MacroErr.given_MacroErr

But given instance given_MacroErr in object MacroErr does not match type MacroErr.,some macro error)

What do you think @nicolasstucki, should I file this as a separate issue and we let this one be merged as-is, or should we investigate further why non-transparent inline method wrappers fail in this particular area?

[nicolasstucki]

File it as a separate issue.

[soronpo]

Can we merge this?