Skip to content

Ignore dots in artifactIds when updating versions #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Ignore dots in artifactIds when updating versions #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/core/src/main/scala/org/scalasteward/core/model/Update.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ sealed trait Update extends Product with Serializable {
.map { term =>
Regex
.quoteReplacement(Update.removeCommonSuffix(term))
.replace(".", ".?")
.replace("-", ".?")
}
.filter(_.nonEmpty)
Expand Down
9 changes: 8 additions & 1 deletion modules/core/src/test/scala/org/scalasteward/core/model/UpdateTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ class UpdateTest extends FunSuite with Matchers {
).replaceAllIn(original) shouldBe None
}

test("replaceAllIn:") {
test("replaceAllIn: ignore previous") {
val original =
"""val circeVersion = "0.10.0"
|val previousCirceIterateeVersion = "0.10.0"
Expand All @@ -138,6 +138,13 @@ class UpdateTest extends FunSuite with Matchers {
).replaceAllIn(original) shouldBe Some(expected)
}

test("replaceAllIn: artifactId with dot") {
val original = """ def plotlyJs = "1.41.3" """
val expected = """ def plotlyJs = "1.43.2" """
Single("org.webjars.bower", "plotly.js", "1.41.3", Nel.of("1.43.2"))
.replaceAllIn(original) shouldBe Some(expected)
}

test("replaceAllInRelaxed") {
val original = """lazy val circeVersion = "0.9.3""""
val expected = """lazy val circeVersion = "0.11.1""""
Expand Down