-
Notifications
You must be signed in to change notification settings - Fork 21
Cross build to sbt 2.0.0-RC6 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
036c53a to
5f8ec25
Compare
build.sbt
Outdated
| val packager19xVersion = "1.9.16" | ||
|
|
||
| val scala212 = "2.12.20" | ||
| val scala3 = "3.7.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naive question out of curiosity: we can use Scala 3.7 in the plugin because SBT 2.x itself is in Scala 3.7, right? I ask because I was expecting to see a Scala 3 LTS version (3.3.x) to ensure the plugin can be consumed in various version of SBT 2.x but I guess SBT 2.x (not RC) won't be released until the next LTS anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt 2.x doesn't follow LTS since it on its own isn't a library, and sbt using the latest allows greater flexibility in the plugin ecosystem.
|
Some of the failing tests are more to do with sbt 2 rather than the plugin itself, so I've moved them into a different directory so sbt 1.x would test it but not sbt 2.x. |
|
@eed3si9n can you update to latest RC? Thanks! |
5b37e32 to
1aa0464
Compare
|
sbt 2.0.0-RC7 has a known issue, so I used RC6 here. |
1aa0464 to
237627f
Compare
|
I see pipeline is OK, can we merge it and cut a release? |
|
Thanks @eed3si9n , really appreciated :) |
Fixes #43