Skip to content

Conversation

@eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Sep 8, 2025

Fixes #43

@eed3si9n eed3si9n mentioned this pull request Sep 8, 2025
@eed3si9n eed3si9n force-pushed the wip/cross-build branch 2 times, most recently from 036c53a to 5f8ec25 Compare September 8, 2025 15:01
@eed3si9n eed3si9n marked this pull request as draft September 8, 2025 15:03
build.sbt Outdated
val packager19xVersion = "1.9.16"

val scala212 = "2.12.20"
val scala3 = "3.7.2"
Copy link
Contributor

@gaeljw gaeljw Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naive question out of curiosity: we can use Scala 3.7 in the plugin because SBT 2.x itself is in Scala 3.7, right? I ask because I was expecting to see a Scala 3 LTS version (3.3.x) to ensure the plugin can be consumed in various version of SBT 2.x but I guess SBT 2.x (not RC) won't be released until the next LTS anyway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbt 2.x doesn't follow LTS since it on its own isn't a library, and sbt using the latest allows greater flexibility in the plugin ecosystem.

@eed3si9n eed3si9n marked this pull request as ready for review September 10, 2025 04:15
@eed3si9n
Copy link
Member Author

Some of the failing tests are more to do with sbt 2 rather than the plugin itself, so I've moved them into a different directory so sbt 1.x would test it but not sbt 2.x.

@mkurz
Copy link
Member

mkurz commented Dec 1, 2025

@eed3si9n can you update to latest RC? Thanks!

@eed3si9n
Copy link
Member Author

eed3si9n commented Dec 1, 2025

sbt 2.0.0-RC7 has a known issue, so I used RC6 here.

@eed3si9n eed3si9n changed the title Cross build to sbt 2.0.0-RC4 Cross build to sbt 2.0.0-RC6 Dec 1, 2025
@gaeljw
Copy link
Contributor

gaeljw commented Dec 10, 2025

I see pipeline is OK, can we merge it and cut a release?

@eed3si9n eed3si9n merged commit 1dc2f9a into master Dec 11, 2025
2 checks passed
@eed3si9n eed3si9n deleted the wip/cross-build branch December 11, 2025 04:37
@eed3si9n
Copy link
Member Author

@gaeljw
Copy link
Contributor

gaeljw commented Dec 11, 2025

Thanks @eed3si9n , really appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sbt 2

4 participants