Skip to content

fix 15, 16, 17, 18, 19 issue #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Nika-Soltani-Tehrani
Copy link

@Nika-Soltani-Tehrani Nika-Soltani-Tehrani commented Mar 15, 2023

Fixes # by...

Changes proposed in this pull request:

  • Changed the format of converting five numbers include (15, 16, 17, 18, 19)

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Fill out this section so that a reviewer can know how to verify your change.
By testing the num2words/lang_FA.py file and calling the 'cardinal3' function, when you should see the below result:

num2word_fa = Num2Word_FA()
number = int('۱۹')
modified_number = num2word_fa.cardinal3(number)
print(modified_number)
# result: نوزده

Before this change, the result was 'نه و ده' which is wrong.
Also for numbers ۱۵, ۱۶, ۱۷, ۱۸ it has to result in: 'هجده', 'هفده', 'شانزده', 'پانزده'

Additional notes

If applicable, explain the rationale behind your change.
This problem was a little but impactful mistake in using the formal Persian language, not the informal one.

@coveralls
Copy link

Coverage Status

Coverage: 97.171% (+0.0005%) from 97.17% when pulling 77fbe91 on Nika-Soltani-Tehrani:fix-numbers-issue into 3ef32f0 on savoirfairelinux:master.

@mrodriguezg1991 mrodriguezg1991 merged commit 5bacc2b into savoirfairelinux:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants