-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade react-scripts from 1.1.5 to 2.0.3 #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ent/time-slicing/yarn.lock to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-JSYAML-13961110
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, aims to fix a prototype pollution vulnerability in js-yaml by upgrading react-scripts from version 1.1.4 to 2.0.3. While this does resolve the security issue, this is a major version upgrade for react-scripts which introduces breaking changes. Specifically, the new version of react-scripts is incompatible with the experimental version of React used in this fixture. This will likely break the build. I've provided a comment with a safer alternative using yarn resolutions to patch the vulnerability without the disruptive upgrade. I recommend adopting that approach instead.
| "react-dom": "0.0.0-experimental-269dd6ec5", | ||
| "react-markdown": "^3.2.0", | ||
| "react-scripts": "^1.1.4", | ||
| "react-scripts": "^2.0.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this upgrade to react-scripts@^2.0.3 fixes the js-yaml vulnerability, it's a major version bump from 1.x to 2.x. This new version of react-scripts requires react@^16.3.2 and react-dom@^16.3.2, but this project uses the highly experimental 0.0.0-experimental-269dd6ec5 versions. This incompatibility is very likely to break this fixture.
A safer approach to fix the security vulnerability without introducing breaking changes would be to use yarn resolutions to force js-yaml to a secure version. You can do this by adding the following to this package.json and running yarn install:
"resolutions": {
"js-yaml": "^3.13.1"
}I recommend reverting this change and using the resolutions method instead.
| "react-scripts": "^2.0.3", | |
| "react-scripts": "^1.1.4", |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
fixtures/concurrent/time-slicing/package.jsonfixtures/concurrent/time-slicing/yarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-JSYAML-13961110
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution