-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade @angular/compiler from 5.2.9 to 19.2.17 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ANGULARCOMPILER-14157154
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, addresses a critical security vulnerability by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades @angular/compiler from version 5.2.9 to 19.2.17 to fix a security vulnerability. While addressing the vulnerability is important, this is a massive major version jump that introduces significant breaking changes. More critically, it only upgrades @angular/compiler while leaving all other @angular/* packages (like @angular/core and @angular/common) and related tooling (like @angular/cli and TypeScript) at versions compatible with Angular 5. Angular's packages are tightly coupled and must be on the same version. This mismatch will break the application. Therefore, this PR is not safe to merge in its current state. A full, manual migration of the entire Angular framework is necessary to properly upgrade, which will involve addressing numerous breaking changes across the codebase.
| "@angular/animations": "^5.2.9", | ||
| "@angular/common": "^5.2.9", | ||
| "@angular/compiler": "^5.2.9", | ||
| "@angular/compiler": "^19.2.17", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade of @angular/compiler to version 19.2.17 is a significant breaking change, especially since other @angular packages like @angular/core (line 23), @angular/common (line 21), and @angular/compiler-cli (line 51, in devDependencies) remain on version 5.2.9. Angular packages are tightly coupled and must be kept on the same version to ensure compatibility. This version mismatch will almost certainly break your application's build and runtime.
A proper upgrade from Angular 5 to 19 is a major migration effort and involves more than just this one package. Key considerations include:
- Updating all
@angular/*packages: All framework packages must be on the same version. - Migrating from
@angular/http: The@angular/httpmodule (line 25) was removed in Angular 8. You'll need to migrate to@angular/common/http. - Updating RxJS: Your project uses RxJS 5. Newer Angular versions require RxJS 6 or 7, which has many breaking changes.
- Updating TypeScript and CLI: You'll also need to update TypeScript (currently
~2.5.3) and@angular/cli(currently~1.7.3) to versions compatible with Angular 19.
This automated PR is not safe to merge. It's recommended to perform a full, careful Angular migration, potentially using the official Angular update guide (update.angular.io) as a starting point.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonyarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-ANGULARCOMPILER-14157154
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)