[sheets-] on reload, fetch fresh data for URLs #2835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saulpw
reviewed
Aug 10, 2025
| sheet.source.is_url() and sheet.source.scheme != 'file': #2825 | ||
| #retrieve data again, because the earlier data saved in sheet.source may be outdated | ||
| vs = vd.openSource(Path(sheet.source.given)) | ||
| if type(vs) != type(sheet): #new data may have a different filetype |
There was a problem hiding this comment.
I think there's a more Pythonic way to do this. is or isinstance? But I'm not sure, and I don't think it's a big deal.
saulpw
approved these changes
Aug 10, 2025
Co-authored-by: anjakefala <[email protected]>
anjakefala
force-pushed
the
http_reload
branch
from
a51a3df to
5f4177b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2825.
The problem was that for URLs, the initial content of the URL is saved in in
sheet.source(avisidata.Pathobject) inside aRepeatFile. Reloading the sheet merely reread the saved contents.