-
-
Notifications
You must be signed in to change notification settings - Fork 810
[Feature]: Switch blog layout to fullscreen overriding global.css #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I agree we could refactor some layout classes (especially Screen.Recording.2025-03-22.at.5.04.51.PM.mov |
|
Could you give me some example using "utility-classes" 😀 And I. Couldn't see the issue in your video 🥲 |
3035aa0 to
7f2c535
Compare
Well I moved this to #box inside of global.css and removed the
ohhh now I saw the diff, I am trying to find where I changed ... Edit: I don't know why |
6e2ec54 to
6f8bcbe
Compare
It was added a box div wrapping the whole structure, it will be easier to change the layout when it is needed. Added layout for structure astro-paper structure
|
Hey @satnaing I fixed the footer issue. is it missing something else? |
|
Hi @eerison After checking thoroughly throughout all the changes in this PR, I realized that we can approach this issue by only using a universal tailwind We've used `mx-auto flex max-w-3xl flex-col items-center justify-between sm:flex-row` // Header
`max-w-3xl mx-auto ${noPadding ? "px-0" : "px-4"}`; // Hr
`mx-auto prose mt-8 max-w-3xl` // PostDetails
`mx-auto w-full max-w-3xl px-4 pb-12` // PostDetails #main-content
`mx-auto flex max-w-3xl flex-1 items-center justify-center` // 404
`mx-auto max-w-3xl px-4` // Footer
`mx-auto w-full max-w-3xl px-4 pb-4` // Main
`prose mb-28 max-w-3xl prose-img:border-0` // AboutLayout
`mx-auto mt-8 mb-1 w-full max-w-3xl px-4`; // Breadcrumb;
`mx-auto flex w-full max-w-3xl items-center justify-start px-2`; // BackButtonWe can get the desired result by changing But we can do better by extracting So, there's another question. Why don't we extract other classes like This is because with every additional extracted class (apart from For example, let's say we extract @utility awesome-class {
@apply mx-auto max-w-full;
}Now, we can replace I'll make a PR to solve this issue, and you can leave your opinion on that as well. |


Description
I have added a box div into the
Layout.astro, with this we can change the blog's layout tofull screenif we want :)e.g:
custom.css
Screencast.from.2025-03-21.18-32-10.webm
Types of changes
Checklist