Skip to content

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Nov 13, 2017

Fixes #213
Fixes #210

@mgreter mgreter merged commit b8281a2 into sass:master Nov 13, 2017
@ari
Copy link

ari commented Apr 12, 2018

This was a very unkind change. In a minor bug fix update from 3.4.7 to 3.4.8 you change the API of the application so that the old configuration no longer worked.

That not how versioning works. Remember that some people use this app in business automation processes and we don't expect breaking changes like this.

@mgreter
Copy link
Contributor Author

mgreter commented Apr 12, 2018

First of thanks for your unkind words. If you would have checked the change you might have realized that it was not intentional. I do this work for no money on my free time. You could have just opened a bug report as most other people do. See #226 for a fix and I challenge you to do the testing that this change does not regress in any other way on linux, windows or mac. Have a nice day!

@ari
Copy link

ari commented Apr 13, 2018

Ah, you are correct. I hadn't seen in the source that you intended for this to be optional. I thought it was supposed to be a breaking change.

Sorry about that and thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants