Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

feat: Switch to node-pre-gyp #2452

Closed
wants to merge 19 commits into from
Closed

feat: Switch to node-pre-gyp #2452

wants to merge 19 commits into from

Conversation

nschonni
Copy link
Contributor

Just rebased this, haven't tested it so I'll see what the CI says

xzyfer and others added 17 commits July 17, 2018 00:44
@xzyfer
Remove unsupported Node versions from CI
5cf03b8
@xzyfer
Replace Gaze with Chokidar
9019c68
@xzyfer
Bump meow@^4.0.0
fe36272
@xzyfer
Bump cross-spawn@^6.0.5
e2064f9
@xzyfer
Bump chalk@^2.3.2
2c8c519
@xzyfer
Bump get-stdin@^6.0.0
5456870
@xzyfer
Bump mocha@^5.0.5
c8d53f5
@xzyfer
Bump fs-extra@^5.0.0
cde6ce9
@xzyfer
Bump eslint@^4.19.1
6482ae7
@xzyfer
Remove deprecated process.sass API
7c4cc06
@realityking @xzyfer
Remove workarounds for old Node.js versions
103e2eb
@realityking @xzyfer
Drop lodash.assign in favor of the native Object.assign
ca8f1d4
@realityking @xzyfer
Indicate the supported Node.js version in package.json
76be3bf
@realityking @xzyfer
Move lodash.mergewith from dependencies to dev-dependencies.
56ca50e 
It's only used in a test.
@xzyfer
Compile on watch
73c5ceb
@xzyfer
Don't watch or compile .css files
6d6e407 
This was a non-standared feature in LibSass we had to support. It
is being removed in LibSass 3.6.0.

This prevents people from output their source directory.

See sass/libsass#2611
See sass#2184
See sass#2006
See sass#1933
See sass#1925
See sass#1867
See sass#1845
@nschonni
feat: Switch to node-pre-gyp
b9b9bd9
@nschonni nschonni requested a review from xzyfer July 19, 2018 03:48
@nschonni nschonni mentioned this pull request Jul 19, 2018
Closed
@xzyfer
Copy link
Contributor

xzyfer commented Jul 19, 2018

So I ran into these failures during my N-API work and was scratching my head for a good while. Turns out a bunch of tests have always been broken due to a subtle bug introduced into the CLI test 4 years ago (535b524#diff-583d616f4b01bf1fa153e71c0cef7de7R98).

For some reason a recent change to some Node LTS versions, or AppVeyor itself has caused the run order of tests to change which surfaced this error.

I have applied a patch the v5 branch (4b05387). Re-rebase this PR and your CI troubles should go away.

@xzyfer
Copy link
Contributor

xzyfer commented Jul 19, 2018

Given our chat is it correct that is blocked on mapbox/node-pre-gyp#402?

@nschonni
Copy link
Contributor Author

Depends if we want to try and support both at the same time

@xzyfer
Copy link
Contributor

xzyfer commented Jul 19, 2018 via email

@springmeyer
Copy link

Given our chat is it correct that is blocked on mapbox/node-pre-gyp#402?

This is now released in [email protected]

@nschonni
Copy link
Contributor Author

nschonni commented Jun 7, 2019

Came across https://github.com/JCMais/node-libcurl which has a good node-pre-gyp setup, but they're not doing N-API right now

@xzyfer xzyfer force-pushed the v5 branch 3 times, most recently from 55a5f73 to 6fdfdc6 Compare November 7, 2019 10:52
@xzyfer xzyfer force-pushed the v5 branch 2 times, most recently from 6b1387c to b186df6 Compare November 7, 2019 11:31
@codler
Copy link

codler commented Dec 5, 2019

Will this replace node-gyp?

@nschonni
Copy link
Contributor Author

nschonni commented Dec 5, 2019

@codler no, it is just as an alternate to our custom build scripts to pull down pre-built binaries. All native modules in node use node-gyp as the fallback build.

@nschonni nschonni closed this Apr 26, 2022
@enterstudio enterstudio mentioned this pull request May 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 14, 2022
Open
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
@xzyfer
Fix parsing of @supports declarations
60f8391 
Emulate the parse behaviour of `@media` query declarations.

Fixes sass#2452
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xzyfer xzyfer Awaiting requested review from xzyfer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nschonni @xzyfer @springmeyer @codler @realityking