Add support for % as a stand-alone expression
#2540
Conversation
This also deprecates user-defined functions named "type". See #2539
| /// Deprecation for functions named "type". | ||
| typeFunction( | ||
| 'type-function', | ||
| deprecatedIn: '1.86.0', | ||
| description: 'Functions named "type".', | ||
| ), | ||
|
|
There was a problem hiding this comment.
off-topic: for whatever reason when I generate the deprecations I end up getting a different formatting, like:
typeFunction('type-function', deprecatedIn: '1.86.0',
description: 'Functions named "type".'),do you happen to know what that would be? this is when running dart run grinder... I guess I may have some config file somewhere that tells dart to behave this way 🤔
There was a problem hiding this comment.
I saw something similar and I couldn't figure out exactly what it was. The Dart formatter is in the process of rolling out new changes so it's probably something related to that, but I don't know what exactly. I suspect making the generator add a trailing comma would force it to behave the same way for both the old and new formatter logic, though.
|
|
||
| if (operator == BinaryOperator.modulo && !_lookingAtExpression()) { | ||
| addSingleExpression(StringExpression.plain( | ||
| '%', scanner.spanFromPosition(scanner.position - 1))); |
There was a problem hiding this comment.
shouldn't this take the position before consuming whitespaces, so that it is actually the operator span ?
There was a problem hiding this comment.
Yeah, that's true. Want to send a fix?
This also deprecates user-defined functions named "type".
See #2539
[see sass/sass#4045]
[see sass/sass-spec#2051]