Skip to content

Conversation

@ahopkins
Copy link
Member

Closes #2558

@ahopkins ahopkins requested a review from a team as a code owner December 18, 2022 11:48
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Base: 88.615% // Head: 88.659% // Increases project coverage by +0.044% 🎉

Coverage data is based on head (7b67189) compared to base (4744a89).
Patch coverage: 0.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2635       +/-   ##
=============================================
+ Coverage   88.615%   88.659%   +0.044%     
=============================================
  Files           82        82               
  Lines         6746      6746               
  Branches      1152      1152               
=============================================
+ Hits          5978      5981        +3     
+ Misses         529       528        -1     
+ Partials       239       237        -2     
Impacted Files Coverage Δ
sanic/server/runners.py 89.156% <0.000%> (ø)
sanic/http/http1.py 83.561% <0.000%> (-0.685%) ⬇️
sanic/server/websockets/impl.py 38.479% <0.000%> (+0.921%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 911485d into main Dec 18, 2022
@ahopkins ahopkins deleted the windows-sock-share branch December 18, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'share' when using the async server

2 participants