Use digitalWrite mode for PWM0 when values are 0 and 255 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaxxz
reviewed
Oct 18, 2016
| if (value === 0) { | ||
| this.pinMode('PWM0', 1); | ||
| this.digitalWrite('PWM0', 0); | ||
| } else if (value === 255) { |
There was a problem hiding this comment.
@jmaxxz so should the entire } else if (value === 255) { be removed?
If this looks fine in your testing, I can make the change and update the PR.
There was a problem hiding this comment.
Sorry for the delays, had the chip with my project on it break. Be a bit more responsive once get the spare spun up.
But yes, 255 works fine without switching to digital mode.
There was a problem hiding this comment.
Doesn't led.on() call analog write with a value of 255?
I think Arduino code also has special checks like this so that 0 maps to LOW and 255 maps to HIGH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24.
Can be tested via
npm install sandeepmistry/chip-io#pwm-fixes.