Query.php patch #18
Open
Query.php patch #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to reload parent queryScalar() method in case it refer on yii/db/Query object in last return statement instead of static instance. It leads to errors in createCommand next call because you also reload build() method in your QueryBuilder class that has own specific method calls like buildSample(), buildPreWhere(), buildWithTotals().
|
Hey, you have an example code with an error? |
|
up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to reload parent queryScalar() method in case it refer on yii/db/Query object in last return statement instead of static instance. It leads to errors in createCommand next call because you also reload build() method in your QueryBuilder class that has own specific method calls like buildSample(), buildPreWhere(), buildWithTotals().