Skip to content

Conversation

@jeriox
Copy link

@jeriox jeriox commented Dec 4, 2025

todo

  • rework Consequence part
  • pass the right "mode" back to the widget in decompress()
  • handle other modes that do not require all fields
  • fix labels

@jeriox jeriox marked this pull request as ready for review December 6, 2025 21:26
@samuelson-ben samuelson-ben merged commit 368c06b into samuelson-ben:standart-expiration-time Dec 7, 2025
@samuelson-ben
Copy link
Owner

@jeriox
I tried your code an found an error (import and export). I probably will look over it tomorrow.
That I merged it already wasn't planed and was simply a mistake.

register_model_for_logging(
Qualification,
ModelFieldsLogConfig(),
ModelFieldsLogConfig(unlogged_fields=["default_expiration_time"]),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should log this, but need some code to make our custom type serializable

@jeriox
Copy link
Author

jeriox commented Dec 13, 2025

@jeriox I tried your code an found an error (import and export). I probably will look over it tomorrow. That I merged it already wasn't planed and was simply a mistake.

what kind of error? I suppose that you cannot run this locally as you changed your database in a way that is different to the migrations included in this PR. you probably need to delete your database and run the migrations again to be able to use this locally.

@samuelson-ben
Copy link
Owner

@jeriox I tried your code an found an error (import and export). I probably will look over it tomorrow. That I merged it already wasn't planed and was simply a mistake.

what kind of error? I suppose that you cannot run this locally as you changed your database in a way that is different to the migrations included in this PR. you probably need to delete your database and run the migrations again to be able to use this locally.

Hi, one bug was on my side. The other one is with the qualification export (/settings/qualifications/export/)
Error: Object of type RelativeTime is not JSON serializable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants