feat: Add comprehensive tax classes and tax configuration support #101
+20,786
−7,480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update GraphQL queries to use parent/level fields instead of children - Fix introspection to build proper tree structure from flat API data - Enhance category service to handle unlimited nesting depth recursively - Add comprehensive tests for multi-level category hierarchies - Ensure round-trip integrity for nested category configurations
- Add tax class management with country-specific rates (0-100%) - Add channel-level tax configuration settings - Support both FLAT_RATES and TAX_APP calculation strategies - Integrate tax classes with products and shipping methods - Include full introspect, deploy, and diff operations - Add comprehensive test coverage with edge cases Tax classes are deployed early in the pipeline (before products/shipping) to ensure dependencies are satisfied. The implementation supports idempotent operations and maintains round-trip integrity between introspect and deploy cycles. 🤖 Generated with Claude Code (https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🦋 Changeset detectedLatest commit: 5d5c000 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Fix async/await in tax-schema.test.ts for all test cases - Add strict validation to channel and tax configuration schemas - Update config-service test to expect taxClasses field - Ensure tax class names are non-empty strings
- Fix import ordering in tax-service.ts - Add missing newlines at end of files - Apply consistent formatting across all tax module files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds tax management support to Saleor Configurator for defining tax classes with country-specific rates and channel tax configurations.
What's New
Example Configuration
Technical
anytypes✅ All tests passing
✅ No linting errors
✅ Round-trip integrity verified