Respect org-hide-leading-stars and the org-hide face #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already thought of in orgmode (see hide-leading-stars), we shouldn't reimplement it in org-bullets. Also it sort of didn't work in terminals.
|
This adresses #16 |
|
Thanks for that, have been struggling with what was causing this! |
* org-bullets.el (org-bullets-bullet-map): Fix documentation style. (org-bullets-level-char): Add docstring.
* org-bullets.el (org-bullets-face-name): Change customization type for nil or a face. This allows auto-completing a face.
* org-bullets.el (org-bullets-mode): Replace the use of the interactive-only function `font-lock-fontify-buffer` to `font-lock-flush`.
Remove importing the `cl` feature since it’s not used anywhere
* org-bullets.el (org-bullets-mode): Use `add-text-properties` instead of `put-text-property`. Add higlight mouse-face and help-echo message.
* org-bullets.el (org-bullets-compose-leading-stars): Add customization variable to set the composition behavior (replace characters). (org-bullets--char-series): Add function to calculate the current character from a series and the current level. (org-bullets-mode): Add the series variable. Add pattern matching case for setting the series variable according to `org-bullets-compose-leading-stars`.
* org-bullets.el (org-bullets--bullet-events): Rename `org-bullets-bullet-map` to `org-bullets--bullet-events` in order to include other event text-properties. (org-bullets-mode): Use `org-bullets--bullet-events` instead of hard-coding text properties.
* org-bullets.el (org-bullets-mouse-events): Add this customization variable to disable mouse events easily. (org-bullets-mode): Refactor to only activate mouse events when `org-bullets-mouse-events` is set.
* org-bullets.el (org-bullets-face-name): Add quote to symbol.
|
Removing code, fixes oddness, what could be better? Really hope to see this merged and pushed to MELPA, would be a shame to have to maintain a fork just for this fix. |
Add several customization variables
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically removes a feature since org-mode already has it.