-
Notifications
You must be signed in to change notification settings - Fork 20
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Hi and thanks for this library, it really ease things up.
I have detected that when you use WebSocketServer and go and try to establish an HTTP connection to the websocket port the server crashes and closes.
While I obviously don't expect the WS server to work properly when being contacted by the wrong protocol it should fail silently, or at least, allow the programmer to specify an error callback in case things like this occur.
I know that the error is indeed generated by Deno's std library ws. However I think if possible it should be handled here.
Steps to reproduce
deno run --allow-net https://deno.land/x/[email protected]/example/server.ts
- Open http://localhost:8080/
- Now the server has crashed
Thanks.
ryo-ma and Josema
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed