Skip to content

Conversation

@HongJungKim-dev
Copy link
Collaborator

🤷‍♂️ Description

  • 기존의 html구조로 작성된 alert를 view 클래스로 리팩토링
  • 취소 버튼 누를시 alert hidden시키기
  • 오른쪽 버튼 누를시 작동할 함수를 인자로 받기 , 취소 버튼 누를시 alert hidden시키기

📷 Screenshots

alert.mp4

@HongJungKim-dev HongJungKim-dev added FE Frontend feat new feature labels Apr 11, 2022
@HongJungKim-dev HongJungKim-dev added this to the 프론트엔드 STEP2 milestone Apr 11, 2022
@HongJungKim-dev HongJungKim-dev requested a review from ju-kkim April 11, 2022 04:18
@HongJungKim-dev HongJungKim-dev self-assigned this Apr 11, 2022
@HongJungKim-dev HongJungKim-dev linked an issue Apr 11, 2022 that may be closed by this pull request
3 tasks
@HongJungKim-dev HongJungKim-dev changed the title feat: [#34] alert창 기본 동작 구현 [FE] alert창 기본 동작 구현 Apr 11, 2022
Copy link
Collaborator

@ju-kkim ju-kkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요 이든! 👍🏻
혹시 utils폴더도 js 안에 넣으도 괜찮을까요??
utils 폴더안에 파일도 다 js파일이라서 넣어도 좋을 것 같습니당!!
나머지 코드에 대한 부분은 좋은 것 같고 추가기능 구현하면서 경고창 사용할때 문제 발생이 된다면 그때 수정하면 될 것 같아요!

@HongJungKim-dev HongJungKim-dev merged commit f1a5553 into frontend Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FE Frontend feat new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FE] alert창 기능 구현

2 participants