-
Notifications
You must be signed in to change notification settings - Fork 34
LDK workflow and dockerfile added #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDK workflow and dockerfile added #133
Conversation
eb45e7e
to
78ecfbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on it, I ledt some comments!
This commit adds a workflow for integrating LDK-Sample with Lnprototest. A dockerfile is also added to build LDK-Sample and run Lnprototest against it.
5e762be
to
1f9f247
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last iteration and we are ready to go IMHO
Thanks to work on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Can we open a issue to track the problem that there is with the failing tests?
I will try to patch them by the end of the week!
Sure I will open them! |
This commit adds a workflow for integrating LDK-Sample with Lnprototest. A dockerfile is also added to build LDK-Sample and run Lnprototest against it.