Skip to content

LDK workflow and dockerfile added #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

Psycho-Pirate
Copy link
Contributor

This commit adds a workflow for integrating LDK-Sample with Lnprototest. A dockerfile is also added to build LDK-Sample and run Lnprototest against it.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it, I ledt some comments!

This commit adds a workflow for integrating LDK-Sample with Lnprototest. A dockerfile is also added to build LDK-Sample and run Lnprototest against it.
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last iteration and we are ready to go IMHO

Thanks to work on it

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can we open a issue to track the problem that there is with the failing tests?

I will try to patch them by the end of the week!

@vincenzopalazzo vincenzopalazzo merged commit 19981c3 into rustyrussell:master Apr 1, 2025
2 of 4 checks passed
@Psycho-Pirate
Copy link
Contributor Author

Can we open a issue to track the problem that there is with the failing tests?

I will try to patch them by the end of the week!

Sure I will open them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants