fix: using runner_features and stash_field_from_event inside tests #129
Conversation
Psycho-Pirate
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Thanks @Psycho-Pirate for this but I need to ask why we need this change, and if you can explain it inside the commit body. IIRC this change is needed when different implementations require different features bit by default. I am right about this? If yes can you add a detailed description inside it? Can everyone who reads your code use the commit as separate documentation? |
I think this might be a core-lightning bug because it is passing with LDK |
runner_features provides the features required by an implementation to Lnprototest. stash_field_from_event allows retrieval of information from the message that was just decoded within the `ExpectMsg` event. Using these methods will make Lnprototest more generalised and compatible with other lightning implementations.
Psycho-Pirate
force-pushed
the
upd_3_
branch
from
e7cb81a to
e37306f
Compare
Added a descriptive commit message |
| import pytest | ||
| import time | ||
| from lnprototest.utils import utxo, tx_spendable | ||
|
|
||
|
|
||
| def test_gossip_timestamp_filter(runner: Runner) -> None: | ||
| if runner.has_option("option_gossip_queries") is None: | ||
| unittest.SkipTest("Needs option_gossip_queries") | ||
| pytest.skip("Needs option_gossip_queries") |
There was a problem hiding this comment.
This is a good change, but usually need a separate commit
| @@ -165,7 +165,7 @@ def update_checksums(update1: Optional[Message], update2: Optional[Message]) -> | |||
|
|
|||
| def test_query_channel_range(runner: Runner) -> None: | |||
| if runner.has_option("option_gossip_queries") is None: | |||
| unittest.SkipTest("Needs option_gossip_queries") | |||
| pytest.skip("Needs option_gossip_queries") | |||
Tests are updated to use
runner_featuresandstash_field_from_event, this allows the tests to support multiple lightning implementations at the same time.