Skip to content

Conversation

anirudhrb
Copy link
Collaborator

@anirudhrb anirudhrb commented Sep 9, 2025

Expose PMU to arm64 guests. Fixes the test_pmu_on testcase in CLH.

Summary of the PR

Please summarize here why the changes in this PR are needed.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@jinankjain
Copy link
Contributor

@gamora12 can you please check why is the MSHV CI failing here?

Copy link
Member

@liuw liuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is solely handled by the hypervisor.

Expose PMU to arm64 guests. Fixes the test_pmu_on testcase in CLH.

Signed-off-by: Anirudh Rayabharam <[email protected]>
@anirudhrb
Copy link
Collaborator Author

Assuming this is solely handled by the hypervisor.

Yeah, looks so. The guest doesn't complain and the pmu test in CH also passes.

@anirudhrb anirudhrb merged commit 0985748 into rust-vmm:main Sep 10, 2025
17 of 19 checks passed
@gamora12
Copy link
Collaborator

gamora12 commented Sep 10, 2025

@gamora12 can you please check why is the MSHV CI failing here?

Github has is a limitation that PR raised from forks can't access repository secrets. This is the reason why the CI is failing in this case. I'm currently looking into what can be done to avoid this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants