Rename fns choose_multiple* → sample*; add choose*_iter #1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
force-pushed
the
push-kvlpklxwrypt
branch
from
e67fa45 to
534b292
Compare
|
Note: I don't think we should add I briefly considered deprecating all the |
vks
approved these changes
Apr 25, 2025
dhardy
added a commit
that referenced
this pull request
Aug 12, 2025
dhardy
commented
Aug 12, 2025
dhardy
force-pushed
the
push-kvlpklxwrypt
branch
from
11df11d to
198475a
Compare
|
Rebased. Ready for merge (hopefully). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentryFixes #1620 by:
IndexedRandom::choose_multiple*→sample*IteratorRandom::choose_multiple*→sample*IndexedRandom::choose_iter,choose_weighted_iterI think I'm happy to go with this. @vks, @benjamin-lieser review please.