Weibull doc numerics warning #1509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
approved these changes
Oct 16, 2024
benjamin-lieser
added a commit
to benjamin-lieser/rand
that referenced
this pull request
Oct 24, 2024
benjamin-lieser
added a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a concrete proposal for #1507
I am also fine with not adding it, as the limitations are not specific to our implementation and people can figure this out on their own. I think a short reminder that Weibull does exhaust the floating point limits very quickly is worthwhile.
It also adds the pdf to the documentation, I find this always very helpful to make sure me and the library author using the same parameterization of the distribution.