Skip to content

Conversation

@josephlr
Copy link
Member

Fixes #94

@newpavlov
Copy link
Member

You forgot to add default-features = false to no_std CI test. I think we can merge this and publish an update after the rand_core update lands.

@newpavlov newpavlov requested a review from dhardy August 20, 2019 09:02
setting `default-features = false` in `Cargo.toml`. Without this feature, this
library is `no_std` for every supported target.

However, getting randomness
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting a paragraph with however is never good grammar...

@dhardy
Copy link
Member

dhardy commented Aug 23, 2019

Isn't it the other way around — rand libs are waiting on getrandom 0.2 to be published? A breaking change is a breaking change, regardless of whether users have updated.

@josephlr
Copy link
Member Author

Closing in favor of #96. This change isn't the right way to fix #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trait impl disappeared without bumping major version

3 participants