Linux/Android: Document /dev/random polling considerations. #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2024
josephlr
approved these changes
Jun 4, 2024
Member
josephlr
left a comment
josephlr
left a comment
There was a problem hiding this comment.
Thanks for adding this comment. The logic behind this is certainly nontrivial.
Could we just have this comment be the function-level comment? The existing comment:
// Succeeds once /dev/urandom is safe to read fromIsn't very good and this could replace it.
See the added comment for details.
Contributor
Author
Done. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added comment for details.