Skip to content

Relax requirement for DataMut on SVDCC #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
termoshtt merged 1 commit into from
Aug 28, 2022
Merged

Relax requirement for DataMut on SVDCC #303

termoshtt merged 1 commit into from
Aug 28, 2022

Conversation

@benkay86
Copy link
Contributor

@benkay86 benkay86 commented Jul 27, 2021

The SVDDCInto trait should require self to be DataMut, but for the SVDDC trait we only need self to be Data since we do not own it.

@termoshtt termoshtt merged commit 57393b2 into rust-ndarray:master Aug 28, 2022
@termoshtt
Copy link
Member

termoshtt commented Aug 28, 2022

Thanks!

This is a breaking change since public API changes. But most user code does not change because DataMut struct always implements Data.

@termoshtt termoshtt added the change Compatible change label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

change Compatible change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benkay86 @termoshtt