Skip to content

Conversation

@jturner314
Copy link
Member

This fixes Eig for column-major arrays with real elements. (The previous implementation returned the conjugate of the correct eigenvectors.) It also fixes the tests to correctly test column-major arrays (the previous implementation never tested column-major arrays due to bugs in the tests) and ignore the order of the eigenvalues.

@jturner314 jturner314 added the bug Bug issue, or bug fix change label May 30, 2021
@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #298 (d944821) into master (082f01d) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   89.01%   89.28%   +0.26%     
==========================================
  Files          71       71              
  Lines        3578     3592      +14     
==========================================
+ Hits         3185     3207      +22     
+ Misses        393      385       -8     
Impacted Files Coverage Δ
lax/src/eig.rs 97.00% <100.00%> (+8.00%) ⬆️
ndarray-linalg/tests/eig.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 082f01d...d944821. Read the comment docs.

termoshtt added a commit that referenced this pull request Jun 12, 2021
@termoshtt termoshtt merged commit 419ce95 into rust-ndarray:master Jun 12, 2021
termoshtt added a commit that referenced this pull request Jun 12, 2021
@jturner314 jturner314 deleted the fix-eig branch June 13, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug issue, or bug fix change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants