Skip to content

Add LeastSquaresSvdDivideConquer_ into Lapack trait #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
termoshtt merged 1 commit into from
Jul 24, 2020
Merged

Add LeastSquaresSvdDivideConquer_ into Lapack trait #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lax/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ pub trait Lapack:
+ Eigh_
+ Triangular_
+ Tridiagonal_
+ LeastSquaresSvdDivideConquer_
{
}

Expand Down
12 changes: 6 additions & 6 deletions ndarray-linalg/src/least_squares.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ where
/// valid representation for `ArrayBase`.
impl<E, D> LeastSquaresSvd<D, E, Ix1> for ArrayBase<D, Ix2>
where
E: Scalar + Lapack + LeastSquaresSvdDivideConquer_,
E: Scalar + Lapack,
D: Data<Elem = E>,
{
/// Solve a least squares problem of the form `Ax = rhs`
Expand All @@ -175,7 +175,7 @@ where
/// valid representation for `ArrayBase`.
impl<E, D> LeastSquaresSvd<D, E, Ix2> for ArrayBase<D, Ix2>
where
E: Scalar + Lapack + LeastSquaresSvdDivideConquer_,
E: Scalar + Lapack,
D: Data<Elem = E>,
{
/// Solve a least squares problem of the form `Ax = rhs`
Expand All @@ -200,7 +200,7 @@ where
/// valid representation for `ArrayBase`.
impl<E, D> LeastSquaresSvdInto<D, E, Ix1> for ArrayBase<D, Ix2>
where
E: Scalar + Lapack + LeastSquaresSvdDivideConquer_,
E: Scalar + Lapack,
D: DataMut<Elem = E>,
{
/// Solve a least squares problem of the form `Ax = rhs`
Expand All @@ -226,7 +226,7 @@ where
/// valid representation for `ArrayBase`.
impl<E, D> LeastSquaresSvdInto<D, E, Ix2> for ArrayBase<D, Ix2>
where
E: Scalar + Lapack + LeastSquaresSvdDivideConquer_,
E: Scalar + Lapack,
D: DataMut<Elem = E>,
{
/// Solve a least squares problem of the form `Ax = rhs`
Expand Down Expand Up @@ -366,7 +366,7 @@ fn compute_least_squares_nrhs<E, D1, D2>(
rhs: &mut ArrayBase<D2, Ix2>,
) -> Result<LeastSquaresResult<E, Ix2>>
where
E: Scalar + Lapack + LeastSquaresSvdDivideConquer_,
E: Scalar + Lapack,
D1: DataMut<Elem = E>,
D2: DataMut<Elem = E>,
{
Expand All @@ -376,7 +376,7 @@ where
singular_values,
rank,
} = unsafe {
<E as LeastSquaresSvdDivideConquer_>::least_squares_nrhs(
E::least_squares_nrhs(
a_layout,
a.as_allocated_mut()?,
rhs_layout,
Expand Down