linfa-nn: bump kdtree to 0.7.0 #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.6 has a known issue causing stack overflows on specific inputs, see mrhooray/kdtree-rs#42 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
- Coverage 36.09% 36.02% -0.08%
==========================================
Files 99 99
Lines 6502 6496 -6
==========================================
- Hits 2347 2340 -7
- Misses 4155 4156 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! |
|
Thanks for the quick merge @relf! Any chance you could cut linfa 0.7.2 sometime? Would love to get this and other recent patches into a stable release. |
|
Well, I would like to get #371 merged before a new release |
|
Yeah that works. Thanks! |
kakserpom
pushed a commit
to kakserpom/linfa
that referenced
this pull request
Jun 10, 2025
0.6 has a known issue causing stack overflows on specific inputs, see mrhooray/kdtree-rs#42 (comment) Co-authored-by: Alex Gessler <[email protected]>
|
Is it ok for you if I release |
|
Yes! this would be perfect. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.6 has a known issue causing stack overflows on specific inputs, see mrhooray/kdtree-rs#42 (comment). Updating kdtree to 0.7 should address this and doesn't seem to cause test regressions.
Pair-programmed with @Colin1860