Skip to content

Conversation

@gkobeaga
Copy link
Contributor

@gkobeaga gkobeaga commented Sep 1, 2022

The incompatibility was fixed for intel-mkl-tool rust-math/intel-mkl-src#68

The current version of linfa is not compatible with ndarray-linalg/intel-mkl-static.

@YuhanLiin
Copy link
Collaborator

I think you can remove the anyhow dependency altogether

@gkobeaga
Copy link
Contributor Author

gkobeaga commented Sep 2, 2022

Yes, much better. In order to maintain the commit history clean and get rid of this last commit, do you have any preference? Or is it ok if I add a new commit on top of it?

@YuhanLiin
Copy link
Collaborator

New commit is fine. Also can you update the MSRV in CI to 1.59 to avoid the CI errors?

@gkobeaga
Copy link
Contributor Author

gkobeaga commented Sep 7, 2022

It seems that ndarray-linalg needs to be updated to version 0.15 (rust-ndarray/ndarray-linalg#320), to support intel-mkl-tool version 0.3.0, which fixes use anyhow::*; (rust-math/intel-mkl-src#70).

I will update it and see if this does not break anything else.

@YuhanLiin YuhanLiin merged commit e206bf4 into rust-ml:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants