Skip to content

Remove unnecessary methods #4034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rami3l merged 1 commit into from
Sep 26, 2024
Merged

Remove unnecessary methods #4034

rami3l merged 1 commit into from
Sep 26, 2024

Conversation

@InfyniteHeap
Copy link

@InfyniteHeap InfyniteHeap commented Sep 26, 2024

Coming from this: #3896 (comment). The get/set_value() are actually the alias of get/set(). So, it should be removed.

rami3l
rami3l approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rami3l rami3l enabled auto-merge September 26, 2024 08:20
@rami3l rami3l added this pull request to the merge queue Sep 26, 2024
Merged via the queue into rust-lang:master with commit 8d18234 Sep 26, 2024
@InfyniteHeap InfyniteHeap deleted the remove branch September 26, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rami3l rami3l rami3l approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@InfyniteHeap @rami3l