rustup-init.sh ksh and zsh compatibility fixes #3475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
approved these changes
Oct 10, 2023
Contributor
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
I'm not very experienced with shell, but these changes seem to make sense to me.
rami3l
previously approved these changes
Oct 10, 2023
rami3l
reviewed
Oct 10, 2023
rami3l
approved these changes
Oct 10, 2023
Member
|
@alexhudspith Sorry, I somehow missed your reply when approving those changes. The |
Contributor
Author
|
@rami3l No problem, thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3388
Fixes #3474
Tested with:
(debian) 0.5.12-2
(ubuntu) Version AJM 93u+m/1.0.0-beta.2 2021-12-17