Less copying during dist installation #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per rust-lang#904 copying the contents of dists out of the extracted staging directory and then later deleting that same staging directory consumes 60s out of a total of 200s on Windows. Wall clock testing shows this patch reduces `rustup toolchain install nightly` from 3m45 to 2m23 for me - including download times etc. I'm sure there is more that can be done, thus I'm not marking this as a closing merge for rust-lang#904.
kinnison
approved these changes
Apr 9, 2019
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
Over all, I think this looks good. I like the cleanup for dest_abs_path() and the copy-vs-move semantics seem sound to me.
If at all possible, I'd love to see if @brson has enough memory of this code area to comment, otherwise given the tests are green I'm okay for merging this.
Contributor
|
I can confirm that this branch has been working fine for me in local testing for 2 days. |
This was referenced Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #904 copying the contents of dists out of the extracted staging
directory and then later deleting that same staging directory consumes
60s out of a total of 200s on Windows.
Wall clock testing shows this patch reduces
rustup toolchain install nightlyfrom 3m45 to 2m23 for me - includingdownload times etc.
I'm sure there is more that can be done, thus I'm not marking this as
a closing merge for #904.