Skip to content

llvm 13 is now not supported #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnTitor merged 2 commits into from
Feb 18, 2023
Merged

llvm 13 is now not supported #1612

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0143b22
llvm 13 is now not supported
tshepang Feb 18, 2023
7afd1f8
address review comment
tshepang Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/llvm-coverage-instrumentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,8 @@ details of the [_LLVM Coverage Mapping Format_][coverage-mapping-format]
(Version 6).[^llvm-and-covmap-versions]

[^llvm-and-covmap-versions]:
The Rust compiler (as of <!-- date-check: --> Jan 2023) supports _LLVM Coverage Mapping Format_ 6.
It was introduced in _LLVM 13_, which is, as of <!-- date-check: Jan 2023 --> this writing,
the minimum supported LLVM version.
The Rust compiler (as of <!-- date-check: --> Feb 2023) supports _LLVM Coverage Mapping Format_ 6.
It was introduced in _LLVM 13_, which was the minimum supported LLVM version [until early 2023].
Copy link
Member

@JohnTitor JohnTitor Feb 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't have to mention the minimum supported version (and even the introduced version) anymore as the contributors/users now have to use the LLVM 14 or later anyway and the format version 6 is generally available there.

The Rust compiler will automatically use the most up-to-date coverage mapping format
version that is compatible with the compiler's built-in version of LLVM.

Expand Down Expand Up @@ -273,6 +272,7 @@ since it will not be called), and adds a new `FunctionCoverage`, with
[mapgen-finalize]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/coverageinfo/mapgen/fn.finalize.html
[coverage-mapping-format]: https://llvm.org/docs/CoverageMappingFormat.html
[add-unused-functions]: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_codegen_llvm/coverageinfo/mapgen/fn.add_unused_functions.html
[until early 2023]: https://github.com/rust-lang/rust/pull/107573

## Testing LLVM Coverage

Expand Down