Make bad_style a silent alias for nonstandard_style
#54251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now only `nonstandard_style` is suggested in `rustc -W help`, but `bad_style` will not produce a warning.
rust-highfive
added
the
S-waiting-on-review
Member
|
Looks good! Perhaps add a test? r=me either way |
This comment has been minimized.
This comment has been minimized.
src/librustc/lint/context.rs
Outdated
| lint_groups: FxHashMap<&'static str, (Vec<LintId>, bool, Option<&'static str>)>, | ||
| /// is used to store the new names of deprecated lint group names and is paired | ||
| /// with `true` if the deprecation is silent. | ||
| lint_groups: FxHashMap<&'static str, (Vec<LintId>, bool, Option<(&'static str, bool)>)>, |
Contributor
There was a problem hiding this comment.
I have no stake in this code so feel free to ignore me, but these tuples seem excessive. Wouldn't it be nicer to have a struct with named fields?
Member
|
Yeah, we should fix that too
…On Sat, Sep 15, 2018, 9:18 PM Robin Kruppe ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/librustc/lint/context.rs
<#54251 (comment)>:
> @@ -69,8 +69,9 @@ pub struct LintStore {
/// Map of registered lint groups to what lints they expand to. The first
/// bool is true if the lint group was added by a plugin. The optional string
- /// is used to store the new names of deprecated lint group names.
- lint_groups: FxHashMap<&'static str, (Vec<LintId>, bool, Option<&'static str>)>,
+ /// is used to store the new names of deprecated lint group names and is paired
+ /// with `true` if the deprecation is silent.
+ lint_groups: FxHashMap<&'static str, (Vec<LintId>, bool, Option<(&'static str, bool)>)>,
I have no stake in this code so feel free to ignore me, but these tuples
seem excessive. Wouldn't it be nicer to have a struct with named fields?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#54251 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABivSHEP6aB_OH7x4e5-pzbT2JgnEnzZks5ubSE5gaJpZM4WqYc6>
.
|
varkor
force-pushed
the
silence-bad_style
branch
from
de5e9a7 to
15ecd19
Compare
Contributor
Author
|
@Manishearth: I did a little refactoring — could you double-check that everything looks fine? |
Contributor
|
Ping from triage @Manishearth / @rust-lang/compiler: This PR requires your review. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 15ecd19 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Oct 16, 2018
Make `bad_style` a silent alias for `nonstandard_style` Now only `nonstandard_style` is suggested in `rustc -W help`, but `bad_style` will not produce a warning. Closes #41646. r? @Manishearth
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only
nonstandard_styleis suggested inrustc -W help, butbad_stylewill not produce a warning. Closes #41646.r? @Manishearth