Make FileMap::{lines, multibyte_chars, non_narrow_chars} non-mutable. #50997

michaelwoerister · 2018-05-23T14:31:19Z

This PR removes most of the interior mutability from FileMap, which should be beneficial, especially in a multithreaded setting. This is achieved by initializing the state in question when the filemap is constructed instead of during lexing. Hopefully this doesn't degrade performance.

cc @wesleywiser

rust-highfive · 2018-05-23T14:31:23Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

michaelwoerister · 2018-05-23T14:31:35Z

@bors try

bors · 2018-05-23T14:31:47Z

⌛ Trying commit fbd1750 with merge 28e2ad9...

@wesleywiser

Make FileMap::{lines, multibyte_chars, non_narrow_chars} non-mutable. This PR removes most of the interior mutability from `FileMap`, which should be beneficial, especially in a multithreaded setting. This is achieved by initializing the state in question when the filemap is constructed instead of during lexing. Hopefully this doesn't degrade performance. cc @wesleywiser

wesleywiser · 2018-05-23T15:20:42Z

Nice job @michaelwoerister! It didn't even occur to me to try this kind of approach. IMO, this code is much easier to follow than the previous version since all of the special character handling is consolidated into one place. 👍

michaelwoerister · 2018-05-23T15:26:40Z

Yes, let's hope performance doesn't throw a wrench into the works :) But it might even be faster, since less locking is going on. In the parallel case it should definitely be faster.

michaelwoerister · 2018-05-23T16:39:11Z

Hm, UI tests also seem to have some trouble...

bors · 2018-05-23T16:40:35Z

☀️ Test successful - status-travis
State: approved= try=True

michaelwoerister · 2018-05-23T16:41:37Z

@Mark-Simulacrum, could I get a perf-run, please?

wesleywiser · 2018-05-23T16:50:28Z

src/libsyntax/parse/lexer/mod.rs


-            if self.ch.unwrap() == '\n' {
-                if self.save_new_lines_and_multibyte {
-                    self.filemap.next_line(self.next_pos);


This checks if the current character is a newline, but then it passes next_pos into next_line

wesleywiser · 2018-05-23T16:50:55Z

src/libsyntax_pos/lib.rs

+            if byte.is_ascii() {
+                match byte {
+                    b'\n' => {
+                        lines.push(byte_pos);


This checks if the current character is a newline and then records the current position. Is this where the off-by one on the failing UI tests is coming from?

Yes, I think that's the problem. Good catch!

michaelwoerister · 2018-05-23T17:07:53Z

Should be fixed now. The perf run should still be valid, despite the change.

Mark-Simulacrum · 2018-05-23T17:11:42Z

Perf queued!

rust-highfive · 2018-05-23T18:33:03Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:23:58] travis_fold:start:test_stage1-syntax
travis_time:start:test_stage1-syntax
Testing syntax stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:23:58]    Compiling syntax v0.0.0 (file:///checkout/src/libsyntax)
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:951:12
[01:24:04]     |
[01:24:04] 951 |         fm.next_line(BytePos(0));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:955:12
[01:24:04]     |
[01:24:04] 955 |         fm.next_line(BytePos(10));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:957:12
[01:24:04]     |
[01:24:04] 957 |         fm.next_line(BytePos(12));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:968:12
[01:24:04]     |
[01:24:04] 968 |         fm.next_line(BytePos(0));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:969:12
[01:24:04]     |
[01:24:04] 969 |         fm.next_line(BytePos(10));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:970:12
[01:24:04]     |
[01:24:04] 970 |         fm.next_line(BytePos(2));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:982:13
[01:24:04]     |
[01:24:04] 982 |         fm1.next_line(BytePos(0));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:983:13
[01:24:04]     |
[01:24:04] 983 |         fm1.next_line(BytePos(12));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:984:13
[01:24:04]     |
[01:24:04] 984 |         fm2.next_line(fm2.start_pos);
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:985:13
[01:24:04]     |
[01:24:04] 985 |         fm3.next_line(fm3.start_pos);
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]    --> libsyntax/codemap.rs:986:13
[01:24:04]     |
[01:24:04] 986 |         fm3.next_line(fm3.start_pos + BytePos(12));
[01:24:04]     |
[01:24:04]     = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1046:13
[01:24:04]      |
[01:24:04] 1046 |         fm1.next_line(BytePos(0));
[01:24:04]      |
[01:24:04]      = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1047:13
[01:24:04]      |
[01:24:04] 1047 |         fm1.next_line(BytePos(28));
[01:24:04]      |
[01:24:04]      = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1048:13
[01:24:04]      |
[01:24:04] 1048 |         fm2.next_line(fm2.start_pos);
[01:24:04]      |
[01:24:04]      = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `next_line` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1049:13
[01:24:04]      |
[01:24:04] 1049 |         fm2.next_line(fm2.start_pos + BytePos(20));
[01:24:04]      |
[01:24:04]      = help: did you mean `get_line`?
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `record_multibyte_char` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1051:13
[01:24:04]      |
[01:24:04] 1051 |         fm1.record_multibyte_char(BytePos(3), 3);
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `record_multibyte_char` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1052:13
[01:24:04]      |
[01:24:04] 1052 |         fm1.record_multibyte_char(BytePos(9), 3);
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `record_multibyte_char` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1053:13
[01:24:04]      |
[01:24:04] 1053 |         fm1.record_multibyte_char(BytePos(12), 3);
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `record_multibyte_char` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1054:13
[01:24:04]      |
[01:24:04] 1054 |         fm1.record_multibyte_char(BytePos(15), 3);
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `record_multibyte_char` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1055:13
[01:24:04]      |
[01:24:04] 1055 |         fm1.record_multibyte_char(BytePos(18), 3);
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `record_multibyte_char` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1056:13
[01:24:04]      |
[01:24:04] 1056 |         fm2.record_multibyte_char(fm2.start_pos + BytePos(10), 3);
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `record_multibyte_char` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1057:13
[01:24:04]      |
[01:24:04] 1057 |         fm2.record_multibyte_char(fm2.start_pos + BytePos(13), 3);
[01:24:04] 
[01:24:04] 
[01:24:04] error[E0599]: no method named `record_multibyte_char` found for type `std::rc::Rc<syntax_pos::FileMap>` in the current scope
[01:24:04]     --> libsyntax/codemap.rs:1058:13
[01:24:04]      |
[01:24:04] 1058 |         fm2.record_multibyte_char(fm2.start_pos + BytePos(18), 3);
[01:24:04] 
[01:24:08] error: aborting due to 23 previous errors
[01:24:08] 
[01:24:08] For more information about this error, try `rustc --explain E0599`.
[01:24:08] For more information about this error, try `rustc --explain E0599`.
[01:24:08] error: Could not compile `syntax`.
[01:24:08] 
[01:24:08] To learn more, run the command again with --verbose.
[01:24:08] 
[01:24:08] 
[01:24:08] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
[01:24:08] 
[01:24:08] 
[01:24:08] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:24:08] Build completed unsuccessfully in 0:39:18
[01:24:08] Build completed unsuccessfully in 0:39:18
[01:24:08] make: *** [check] Error 1
[01:24:08] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1d70ef0a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

michaelwoerister · 2018-05-24T08:51:44Z

Thanks, @Mark-Simulacrum!

michaelwoerister · 2018-05-24T08:53:15Z

Link: http://perf.rust-lang.org/compare.html?start=1962a70e71e82516a4436e00933654a990203c9e&end=28e2ad94d8214d82fd3ad74624897fbce0ab32b5&stat=instructions%3Au

rust-highfive · 2018-05-24T10:50:18Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:42:57] .....................................................i..............................................
[00:43:01] .........................................................................ii.........................
[00:43:07] ....................................................................................................
[00:43:13] ...................................................................................i................
[00:43:15] .iiiiiiiii...................................................
[00:43:15] 
[00:43:15] travis_fold:start:test_ui_nll
travis_time:start:test_ui_nll
Check compiletest suite=ui mode=ui compare_mode=nll (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
[00:44:01] .....................................................i..............................................
[00:44:05] .........................................................................ii.........................
[00:44:10] ....................................................................................................
[00:44:16] ...................................................................................i................
[00:44:18] .iiiiiiiii...................................................
[00:44:18] 
[00:44:18]  finished in 62.980
[00:44:18] travis_fold:end:test_ui_nll

---
[01:17:20] 
[01:17:20] To learn more, run the command again with --verbose.
[01:17:20] 
[01:17:20] 
[01:17:20] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
[01:17:20] 
[01:17:20] 
[01:17:20] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:17:20] Build completed unsuccessfully in 0:36:30
[01:17:20] Build completed unsuccessfully in 0:36:30
[01:17:20] Makefile:58: recipe for target 'check' failed
[01:17:20] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:072c2d5a
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-05-24T17:29:23Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:59:47] .....................................................i..............................................
[00:59:52] .........................................................................ii.........................
[01:00:00] ....................................................................................................
[01:00:07] ...................................................................................i................
[01:00:10] .iiiiiiiii...................................................
[01:00:10] 
[01:00:10] travis_fold:start:test_ui_nll
travis_time:start:test_ui_nll
Check compiletest suite=ui mode=ui compare_mode=nll (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
[01:01:07] .....................................................i..............................................
[01:01:13] .........................................................................ii.........................
[01:01:19] ....................................................................................................
[01:01:27] ...................................................................................i................
[01:01:29] .iiiiiiiii...................................................
[01:01:29] 
[01:01:29]  finished in 79.239
[01:01:29] travis_fold:end:test_ui_nll

---
[01:49:21] travis_fold:start:test_stage1-syntax
travis_time:start:test_stage1-syntax
Testing syntax stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:49:21]    Compiling syntax v0.0.0 (file:///checkout/src/libsyntax)
0m^^^ help: consider using `_fm3` instead
[01:49:37] error: unused variable: `fm1`
[01:49:37]     --> libsyntax/codemap.rs:1077:13
[01:49:37]      |
[01:49:37] 1077 |         let fm1 =
[01:49:37] 1077 |         let fm1 =
[01:49:37]      |             ^^^ help: consider using `_fm1` instead
[01:49:37] error: unused variable: `fm2`
[01:49:37]     --> libsyntax/codemap.rs:1080:13
[01:49:37]      |
[01:49:37]      |
[01:49:37] 1080 |         let fm2 = cm.new_filemap(PathBuf::from("blork2.rs").into(),
[01:49:37]      |             ^^^ help: consider using `_fm2` instead
[01:49:38] error: aborting due to 5 previous errors
[01:49:38] 
[01:49:38] error: Could not compile `syntax`.
[01:49:38] 
[01:49:38] 
[01:49:38] To learn more, run the command again with --verbose.
[01:49:38] 
[01:49:38] 
[01:49:38] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
[01:49:38] 
[01:49:38] 
[01:49:38] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:49:38] Build completed unsuccessfully in 0:52:42
[01:49:38] Build completed unsuccessfully in 0:52:42
[01:49:38] make: *** [check] Error 1
[01:49:38] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2fdadc87
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

michaelwoerister · 2018-05-25T11:30:46Z

I think something might have gone wrong with that previous perf run. Let's do another one.

@bors try

bors · 2018-05-25T11:30:58Z

⌛ Trying commit 2874a87 with merge 23299ed...

@wesleywiser

Make FileMap::{lines, multibyte_chars, non_narrow_chars} non-mutable. This PR removes most of the interior mutability from `FileMap`, which should be beneficial, especially in a multithreaded setting. This is achieved by initializing the state in question when the filemap is constructed instead of during lexing. Hopefully this doesn't degrade performance. cc @wesleywiser

bors · 2018-05-25T13:19:49Z

☀️ Test successful - status-travis
State: approved= try=True

michaelwoerister · 2018-05-25T13:28:17Z

@Mark-Simulacrum, can we give this another try?

michaelwoerister · 2018-06-27T12:09:59Z

Rebased.

@bors r=Mark-Simulacrum

bors · 2018-06-27T12:10:00Z

📌 Commit ba30c1d has been approved by Mark-Simulacrum

bors · 2018-06-27T13:26:14Z

⌛ Testing commit ba30c1d with merge a9880eb97bcb8fac55e8b0b34aac9f42ee11a0f7...

bors · 2018-06-27T14:25:47Z

💔 Test failed - status-appveyor

michaelwoerister · 2018-06-27T16:13:21Z

I can reproduce locally, will investigate.

The method relied on the FileMap still being under construction in order for it to do what the name promises. It's now independent of the current state.

michaelwoerister · 2018-06-28T09:20:59Z

Fixed FileMap::line_begin_pos() which made the incorrect assumption that the "current" line is that last one.

@bors r=Mark-Simulacrum

bors · 2018-06-28T09:21:01Z

📌 Commit a1f8a6c has been approved by Mark-Simulacrum

bors · 2018-06-28T11:20:48Z

⌛ Testing commit a1f8a6c with merge 9f79d2f...

@wesleywiser

…Simulacrum Make FileMap::{lines, multibyte_chars, non_narrow_chars} non-mutable. This PR removes most of the interior mutability from `FileMap`, which should be beneficial, especially in a multithreaded setting. This is achieved by initializing the state in question when the filemap is constructed instead of during lexing. Hopefully this doesn't degrade performance. cc @wesleywiser

bors · 2018-06-28T13:23:03Z

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing 9f79d2f to master...

rust-highfive assigned aturon May 23, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2018

michaelwoerister unassigned aturon May 23, 2018

michaelwoerister added S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2018

wesleywiser reviewed May 23, 2018

View reviewed changes

michaelwoerister force-pushed the pre-analyze-filemaps branch from fbd1750 to 8c8d733 Compare May 23, 2018 17:06

michaelwoerister force-pushed the pre-analyze-filemaps branch from c80e82b to 9a1b838 Compare May 24, 2018 15:36

michaelwoerister force-pushed the pre-analyze-filemaps branch from 9a1b838 to 2874a87 Compare May 25, 2018 09:02

michaelwoerister added 6 commits June 27, 2018 14:00

Remove the now redundant CodeMap::new_filemap_with_lines() method.

095a339

Update CodeMap tests after changing FileMap construction.

04d4da1

Use u32 instead of usize of encoding byte count of multi-byte chars.

3497138

Add SSE2 accelerated version of FileMap analysis.

5a6dc8c

Add comments to analzye_filemap().

ba1d18f

syntax_pos: Store multibyte char size as u8 instead of u32.

ba30c1d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 27, 2018

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2018

Fix FileMap::line_begin_pos().

a1f8a6c

The method relied on the FileMap still being under construction in order for it to do what the name promises. It's now independent of the current state.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 28, 2018

bors merged commit a1f8a6c into rust-lang:master Jun 28, 2018

mati865 mentioned this pull request Jun 29, 2018

Rustup rust-lang/rust-clippy#2880

Merged

nikomatsakis mentioned this pull request Jul 4, 2018

Query Parallelization Tracking Issue #48685

Open

31 tasks

wesleywiser mentioned this pull request Sep 23, 2018

Simplify and optimize FileMap's line/column mapping computation. #44264

Closed

Uh oh!

Make FileMap::{lines, multibyte_chars, non_narrow_chars} non-mutable. #50997

Make FileMap::{lines, multibyte_chars, non_narrow_chars} non-mutable. #50997

Uh oh!

Conversation

michaelwoerister commented May 23, 2018

Uh oh!

rust-highfive commented May 23, 2018

Uh oh!

michaelwoerister commented May 23, 2018

Uh oh!

bors commented May 23, 2018

Uh oh!

wesleywiser commented May 23, 2018

Uh oh!

michaelwoerister commented May 23, 2018

Uh oh!

michaelwoerister commented May 23, 2018

Uh oh!

bors commented May 23, 2018

Uh oh!

michaelwoerister commented May 23, 2018

Uh oh!

wesleywiser May 23, 2018

Choose a reason for hiding this comment

Uh oh!

wesleywiser May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelwoerister May 23, 2018

Choose a reason for hiding this comment

Uh oh!

michaelwoerister commented May 23, 2018

Uh oh!

Mark-Simulacrum commented May 23, 2018

Uh oh!

rust-highfive commented May 23, 2018

Uh oh!

michaelwoerister commented May 24, 2018

Uh oh!

michaelwoerister commented May 24, 2018

Uh oh!

rust-highfive commented May 24, 2018

Uh oh!

rust-highfive commented May 24, 2018

Uh oh!

michaelwoerister commented May 25, 2018

Uh oh!

bors commented May 25, 2018

Uh oh!

bors commented May 25, 2018

Uh oh!

michaelwoerister commented May 25, 2018

Uh oh!

michaelwoerister commented Jun 27, 2018

Uh oh!

bors commented Jun 27, 2018

Uh oh!

bors commented Jun 27, 2018

Uh oh!

bors commented Jun 27, 2018

Uh oh!

michaelwoerister commented Jun 27, 2018

Uh oh!

michaelwoerister commented Jun 28, 2018

Uh oh!

bors commented Jun 28, 2018

Uh oh!

bors commented Jun 28, 2018

Uh oh!

bors commented Jun 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

wesleywiser May 23, 2018 •

edited

Loading