[beta] std: Fix IntoIter::as_mut_slice's signature #39493
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was intended to require `&mut self`, not `&self`, otherwise it's unsound! Closes rust-lang#39465
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
|
Contributor
|
LGTM. I forget, for beta do we just merge directly? |
Member
Author
|
@aturon nowadays we can just r+! |
Contributor
|
@bors: r+ |
Collaborator
|
📌 Commit 2a935f5 has been approved by |
Member
Author
|
@bors: p=1 (PR against beta branch) |
Collaborator
|
⌛ Testing commit 2a935f5 with merge 64add42... |
Member
Author
|
@bors: r- This is gonna fail on beta, need to send another PR |
Collaborator
|
💔 Test failed - status-travis |
Member
Author
|
@bors: retry |
Member
Author
|
@bors: r=aturon |
Collaborator
|
📌 Commit 2a935f5 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Feb 6, 2017
[beta] std: Fix IntoIter::as_mut_slice's signature This is a backport of #39466 to beta
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #39466 to beta