travis: Fix testing 32-bit OSX target #38419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We passed --target when we meant to pass --build, meaning we tested only the standard library for 32-bit, not the whole compiler like we intended.
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
I was wondering why our 32-bit OSX builder was taking so much longer on Travis, and apparently that was because it was testing two targets, not one! This should fix that. |
Contributor
|
@bors r+ p=1 |
Member
Author
|
r? @brson |
Collaborator
|
📌 Commit 0f742e6 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 17, 2016
travis: Fix testing 32-bit OSX target We passed --target when we meant to pass --build, meaning we tested only the standard library for 32-bit, not the whole compiler like we intended.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We passed --target when we meant to pass --build, meaning we tested only the
standard library for 32-bit, not the whole compiler like we intended.