Skip to content

Fix proc macro def ids #37793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Nov 17, 2016
Merged

Fix proc macro def ids #37793

bors merged 2 commits into from
Nov 17, 2016

Conversation

@jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Nov 16, 2016

Update some CStore methods to also work correctly with proc macro def ids.
Fixes #37788.
r? @nrc

@jseyfried jseyfried mentioned this pull request Nov 16, 2016
Closed
@jseyfried jseyfried force-pushed the fix_proc_macro_def_ids branch from 41145b6 to 9690617 Compare November 16, 2016 10:10
@TimNN TimNN mentioned this pull request Nov 16, 2016
Closed
nrc
nrc approved these changes Nov 16, 2016
View reviewed changes
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r = me with a comment on the test

src/test/compile-fail-fulldeps/proc-macro/issue-37788.rs Outdated
Copy link
Member

@nrc nrc Nov 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain what this test is testing in a comment please

@jseyfried jseyfried force-pushed the fix_proc_macro_def_ids branch from 9690617 to 0172e46 Compare November 16, 2016 21:30
@jseyfried
Copy link
Contributor Author

jseyfried commented Nov 16, 2016

@bors r=nrc

@bors
Copy link
Collaborator

bors commented Nov 16, 2016

📌 Commit 0172e46 has been approved by nrc

@est31 est31 mentioned this pull request Nov 16, 2016
Closed
53 tasks
@nox
Copy link
Contributor

nox commented Nov 17, 2016

Please someone prioritise that PR, procedural macros in nightlies are broken.

@jseyfried
Copy link
Contributor Author

jseyfried commented Nov 17, 2016

@bors p=1

@bors
Copy link
Collaborator

bors commented Nov 17, 2016

⌛ Testing commit 0172e46 with merge 5bd1e7f...

bors added a commit that referenced this pull request Nov 17, 2016
@bors
Auto merge of #37793 - jseyfried:fix_proc_macro_def_ids, r=nrc
5bd1e7f 
Fix proc macro def ids

Update some `CStore` methods to also work correctly with proc macro def ids.
Fixes #37788.
r? @nrc
@bors
Copy link
Collaborator

bors commented Nov 17, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 5bd1e7f to master...

@bors bors merged commit 0172e46 into rust-lang:master Nov 17, 2016
sunjay added a commit to sunjay/rhino that referenced this pull request Nov 17, 2016
@sunjay
Started to try and get some basic rust code working. Waiting on rust-…
cc369e7 
…lang/rust#37793 before I can continue
@jseyfried jseyfried deleted the fix_proc_macro_def_ids branch November 17, 2016 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nrc nrc nrc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nrc nrc

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jseyfried @bors @nox @nrc