Skip to content

Conversation

@robinst
Copy link
Contributor

@robinst robinst commented Apr 28, 2015

Part of #24407.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit s/can not/cannot

@nrc
Copy link
Member

nrc commented Apr 28, 2015

Thanks for the PR! r=me with the two nits fixed.

@robinst robinst force-pushed the issue-24407-E0013 branch from b777491 to 6cdb57d Compare April 28, 2015 10:46
@robinst
Copy link
Contributor Author

robinst commented Apr 28, 2015

Fixed the nits and amended the commit.

@alexcrichton
Copy link
Member

@bors: r=nrc 6cdb57d

@Manishearth
Copy link
Member

cc @michaelsproul

@michaelsproul
Copy link
Contributor

@Manishearth: I think this plays nicely with the other approved PR, #24894. Cherry-picking them both didn't require any manual intervention, so I think this means Homu will merge them OK?

The PR for E0010 does clash with E0013 however, so it'll either have to be applied after a rebase or as part of a rollup.

bors added a commit that referenced this pull request Apr 29, 2015
@bors
Copy link
Collaborator

bors commented Apr 29, 2015

⌛ Testing commit 6cdb57d with merge 26c7635...

@bors
Copy link
Collaborator

bors commented Apr 29, 2015

@bors bors merged commit 6cdb57d into rust-lang:master Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants