Skip to content

Let ToString work with unsized types, importantly, str. #20744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into from
Jan 8, 2015
Merged

Let ToString work with unsized types, importantly, str. #20744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libcollections/string.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ pub trait ToString {
fn to_string(&self) -> String;
}

impl<T: fmt::String> ToString for T {
impl<T: fmt::String + ?Sized> ToString for T {
fn to_string(&self) -> String {
use core::fmt::Writer;
let mut buf = String::new();
Expand Down Expand Up @@ -994,6 +994,12 @@ mod tests {
assert_eq!(owned.as_ref().map(|s| s.as_slice()), Some("string"));
}

#[test]
fn test_unsized_to_string() {
let s: &str = "abc";
let _: String = (*s).to_string();
}

#[test]
fn test_from_utf8() {
let xs = b"hello".to_vec();
Expand Down