Avoid O(n^2) performance by checking reduced set of obligations #18386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
force-pushed
the
issue-18208
branch
from
7ec512a to
4e792b1
Compare
Contributor
Author
|
In truth, I don't think we need to be so eager about selecting new obligations. We should probably wait until we want information we don't have, and then try new-obligations and finally all obligations. |
nikomatsakis
changed the title
Contributor
|
lgtm, feel free to r=me after squashing. |
… only when we are about to report an error (rust-lang#18208). I found it is still important to consider the full set in order to make tests like `let x: Vec<_> = obligations.iter().collect()` work.
nikomatsakis
force-pushed
the
issue-18208
branch
from
8b416f2 to
1da73ff
Compare
bors
added a commit
that referenced
this pull request
Oct 28, 2014
Avoid O(n^2) performance by reconsidering the full set of obligations only when we are about to report an error (#18208). I found it is still important to consider the full set in order to make tests like `let x: Vec<_> = obligations.iter().collect()` work. I think we lack the infrastructure to write a regression test for this, but when I did manual testing I found a massive reduction in type-checking time for extreme examples like those found in #18208 vs stage0. f? @dotdash
Contributor
|
LGTM, type checking can now handle enough |
Contributor
Author
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Oct 29, 2024
fix: Handle missing time offsets gracefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid O(n^2) performance by reconsidering the full set of obligations only when we are about to report an error (#18208). I found it is still important to consider the full set in order to make tests like
let x: Vec<_> = obligations.iter().collect()work.I think we lack the infrastructure to write a regression test for this, but when I did manual testing I found a massive reduction in type-checking time for extreme examples like those found in #18208 vs stage0.
f? @dotdash