yet another improvment to rustdoc js typechecking #149327
Conversation
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
A-rustdoc-search
|
r? @notriddle rustbot has assigned @notriddle. Use |
This comment has been minimized.
This comment has been minimized.
| console.log(filterCrates); | ||
|
|
There was a problem hiding this comment.
| console.log(filterCrates); |
There was a problem hiding this comment.
whoops!
yea this was from testing to figure out which type signature was correct.
| if (active) { | ||
| const next = active.nextElementSibling; | ||
| if (next) { | ||
| // @ts-expect-error |
There was a problem hiding this comment.
Please leave a comment explaining why this is okay?
There was a problem hiding this comment.
SvgElement, MathMLElement, and HTMLElement all define .focus()
honestly i'm not even sure what hypothetical element would not have the ability to be focused.
There was a problem hiding this comment.
If the element has tabindex="-1". Although I think the focus method remains available.
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 3ff30e7 (parent) -> 91ab308 (this PR) Test differencesShow 3 test diffs3 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 91ab3083bb2d163dfa408033ac01c73970630cf9 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (91ab308): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.301s -> 471.398s (0.23%) |
…notriddle yet another improvment to rustdoc js typechecking biggest improvment is the docs for `FunctionType` and the signatures for functions that accept names of crates were both slightly wrong, this has now been fixed.
7 participants
biggest improvment is the docs for
FunctionTypeand the signatures for functions that accept names of crates were both slightly wrong, this has now been fixed.