Fix ICE caused by invalid spans for shrink_file #148735
Open
+85
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
cc @Muscraft |
rustbot
added
S-waiting-on-review
Kivooeo
reviewed
Nov 9, 2025
Comment on lines
+1
to
+3
| WARN rustc_errors::emitter Invalid span $SRC_DIR/std/src/macros.rs:LL:COL (#4), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "$SRC_DIR/std/src/macros.rs" }) } | ||
| WARN rustc_errors::emitter Invalid span $SRC_DIR/std/src/macros.rs:LL:COL (#4), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "$SRC_DIR/std/src/macros.rs" }) } | ||
| WARN rustc_errors::emitter Invalid span $SRC_DIR/std/src/macros.rs:LL:COL (#4), error=SourceNotAvailable { filename: Real(Remapped { local_path: None, virtual_name: "$SRC_DIR/std/src/macros.rs" }) } |
Member
There was a problem hiding this comment.
I have worries that this will not pass aarch64-msvc-1 the same way it was in my PR
Member
Author
There was a problem hiding this comment.
ah, it do have the same issue.
Member
Author
There was a problem hiding this comment.
so, I read the discussion on zulip, seems there is another standalone bug. so is it a temprary way we skip Windows for this testcase(and add it back after that bug is fixed)?
Member
|
@bors try jobs=aarch64-msvc-1 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Nov 9, 2025
Fix ICE caused by invalid spans for shrink_file try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
|
💔 Test for eca91bd failed: CI. Failed jobs:
|
Muscraft
reviewed
Nov 9, 2025
nnethercote
approved these changes
Nov 9, 2025
Contributor
|
r=me once the comments are addressed. @rustbot author |
rustbot
added
S-waiting-on-author
chenyukang
force-pushed
the
yukang-fix-ice-148732
branch
from
7262408 to
725b213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148732
There are two issues in this function:
7..7is beyond the end of buffer0) will be reported after fixing the first one, is caused by spans cross file boundaries due to macro expansion. It is fixed in the second commit.r? @nnethercote
edited: also fixes #148684, added a new testcase for it in the last commit.