Skip to content

rustdoc-search: remove broken index special case #148563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Nov 6, 2025
Merged

rustdoc-search: remove broken index special case #148563

bors merged 1 commit into from
Nov 6, 2025
+71 −21

Conversation

@notriddle
Copy link
Contributor

@notriddle notriddle commented Nov 6, 2025

Fixes #148431

@rustbot rustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Nov 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@notriddle
Copy link
Contributor Author

notriddle commented Nov 6, 2025

Or, at least, it should fix it. CC @TomFryersMidsummer to see if it fixes it on your workspace.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 6, 2025

Looks good to me, thanks! r=me whenever you want ;)

@TomFryersMidsummer
Copy link
Contributor

TomFryersMidsummer commented Nov 6, 2025

Yep, this fixes it for us. Thank you!

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 6, 2025

Perfect, approving it then.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 6, 2025

📌 Commit c8b2a9a has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
This was referenced Nov 6, 2025
Closed
Closed
Merged
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 6, 2025
Closed
@bors bors merged commit 1a6770c into rust-lang:master Nov 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 6, 2025
@github-actions github-actions bot mentioned this pull request Nov 7, 2025
Draft
@fmease fmease mentioned this pull request Nov 10, 2025
Closed
@notriddle notriddle deleted the index-typedata-bug branch November 13, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

Rustdoc failed to read column from disk: data consumer error: invalid type: null, expected type data at line 1 column 4

5 participants

@notriddle @rustbot @GuillaumeGomez @TomFryersMidsummer @bors