- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          Implement ~const Fn trait goal in the new solver
          #133216
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    lcnr
  
              
              reviewed
              
                  
                    Nov 19, 2024 
                  
              
              
            
            
              
                    lcnr
  
              
              reviewed
              
                  
                    Nov 19, 2024 
                  
              
              
            
            
              
                    lcnr
  
              
              reviewed
              
                  
                    Nov 19, 2024 
                  
              
              
            
            
              
                    lcnr
  
              
              reviewed
              
                  
                    Nov 19, 2024 
                  
              
              
            
            
        
          
                compiler/rustc_next_trait_solver/src/solve/assembly/structural_traits.rs
          
            Show resolved
            Hide resolved
        
      
              
                    lcnr
  
              
              reviewed
              
                  
                    Nov 19, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits, then r=me
7635073    to
    def7ed0      
    Compare
  
    | @bors r=lcnr rollup | 
      
        
      
      
  
    14 tasks
  
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Nov 20, 2024 
    
    
      
  
    
      
    
  
Rollup of 5 pull requests Successful merges: - rust-lang#132732 (Use attributes for `dangling_pointers_from_temporaries` lint) - rust-lang#133108 (lints_that_dont_need_to_run: never skip future-compat-reported lints) - rust-lang#133190 (CI: use free runner in dist-aarch64-msvc) - rust-lang#133196 (Make rustc --explain compatible with BusyBox less) - rust-lang#133216 (Implement `~const Fn` trait goal in the new solver) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Nov 20, 2024 
    
    
      
  
    
      
    
  
Rollup merge of rust-lang#133216 - compiler-errors:const-fn, r=lcnr Implement `~const Fn` trait goal in the new solver Split out from rust-lang#132329 since this should be easier to review on its own. r? lcnr
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  
    WG-trait-system-refactor
  The Rustc Trait System Refactor Initiative (-Znext-solver) 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Split out from #132329 since this should be easier to review on its own.
r? lcnr