Skip to content

Conversation

@pmur
Copy link

@pmur pmur commented Oct 22, 2025

This PR is a sub-part of rust-lang/rust#147996.

r? @Amanieu

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Oct 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 22, 2025

Failed to set assignee to Amanieu: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@ehuss ehuss added the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Oct 28, 2025
@pmur pmur force-pushed the murp/stabilize-ppc-inlineasm branch 2 times, most recently from da2b26a to 127ffae Compare November 10, 2025 15:46
@pmur pmur force-pushed the murp/stabilize-ppc-inlineasm branch from 127ffae to 0f538c9 Compare December 4, 2025 21:19
Mark status and sticky bits of vscr, fpscr and spefscr as being
preserved when using the `preserves_flags` option. These are not
enforced by codegen today, but might be in future LLVM releases.
@pmur pmur force-pushed the murp/stabilize-ppc-inlineasm branch from 0f538c9 to 3e8ee09 Compare December 10, 2025 20:59
Comment on lines +1355 to +1357
r[asm.rules.stack-above-sp]
- Unless the `nostack` option is set, assembly code is allowed to modify the caller's stack frame in specific cases.
- The target ABI requires storing certain values in the caller's frame (e.g saving the `lr` on PowerPC64)
Copy link
Contributor

@traviscross traviscross Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meaning to say:

When the nostack option is not set, assembly code is allowed to modify the caller's stack frame if and only if the target ABI requires storing values in the caller's frame (e.g., saving the lr on PowerPC64).

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: The marked PR is awaiting review from a maintainer S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants