Need to fix 'miri' bash script for Windows powershell users

[JOE1994]

While trying to work on Issue #707 locally, I got stuck with 'Testing the Miri driver' step. I used Powershell to confront the above error. The current issue is that $MIRI_SYSROOT fed to the miri executable is stripped off of its backslashes, resulting in an error "can't find crate for std"

Maybe the 'miri' bash script should be fixed to escape backslashes for windows users?
Or it could also be an issue with cargo

[RalfJung]

Unfortunately I have no experience with bash scripts on Windows, nor with PowerShell. But I'd happily review a PR trying to fix this. :)

I am surprised the bash script does anything on Windows. I didn't even know PowerShell can run bash...

[RalfJung]

@JOE1994 so now that this works, do you think we could somehow use the miri script for our AppVeyor CI (configured at https://github.com/rust-lang/miri/blob/master/.appveyor.yml ) ?

[JOE1994]

@RalfJung I currently have zero knowledge of AppVeyor CI. I'll need some time to learn about it before I can say something about it 😢

miri/.appveyor.yml

Lines 1 to 6 in 0d01c30

	environment:
	global:
	PROJECT_NAME: miri
	matrix:
	- TARGET: x86_64-pc-windows-msvc
	- TARGET: i686-pc-windows-msvc

Is the AppVeyor script solely for Windows ??
(I assume not, but don't see any TARGETs in the script other than Windows)

[RalfJung]

Yes AppVeyor is for Windows only. So really the main question is: how do I get bash onto Windows? Is that a normal thing for Rust devs to do on Windows?

[JOE1994]

In either Powershell or the Batch shell (2 shells that come with Windows), it is possible to run bash scripts or enter bash shell by using the sh command.

how do I get bash onto Windows? Is that a normal thing for Rust devs to do on Windows?

Maybe I should ask this question to the Rust language forum or the Rust subreddit to find out..
Personally, I try to use bash on Windows when projects only provide bash scripts for building it.

https://users.rust-lang.org/t/is-it-normal-to-use-bash-on-windows-to-build-rust-projects/33628

[RalfJung]

Hm, but sh is not shipped with Windows, right? Don't we need to install it?

[JOE1994]

Oh.. I just realized that sh is not shipped with Windows by default.
One needs to have WSL(Windows Subsystem for Linux) installed and enabled in order to use bash shell in Windows.

[RalfJung]

That still seems to be rather experimental on the AppVeyor side: appveyor/ci#1295.

So, probably best to stick to our current scheme for now. Thanks for testing the script on WSL though, good to know it works now!

[mati865]

Git for Windows ships with bash (bash and sh executables) so anybody who have git will have sh available.