Skip to content

Fix compilation on macOS using clang and fix compilation using zig-cc #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 12, 2025
Merged

Fix compilation on macOS using clang and fix compilation using zig-cc #1364

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c34e0f9
Fix compilation on macOS using clang and fix zig-cc
NobodyXu Jan 12, 2025
c6eeade
Reenable test detecting the regression
NobodyXu Jan 12, 2025
172da47
Fix fmt in tool.rs
NobodyXu Jan 12, 2025
aced6f6
Add comment
NobodyXu Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,10 +428,7 @@ impl Tool {

/// Supports using `--` delimiter to separate arguments and path to source files.
pub(crate) fn supports_path_delimiter(&self) -> bool {
matches!(
self.family,
ToolFamily::Clang { .. } | ToolFamily::Msvc { clang_cl: true }
) && !self.cuda
matches!(self.family, ToolFamily::Msvc { clang_cl: true }) && !self.cuda
}
}

Expand Down
2 changes: 0 additions & 2 deletions tests/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,6 @@ fn gnu_static() {
}

#[test]
// on macOS, cc/gcc is link to apple clang
#[cfg_attr(target_os = "macos", ignore)]
fn gnu_no_dash_dash() {
let test = Test::gnu();
test.gcc().file("foo.c").compile("foo");
Expand Down
Loading